[SPARK-39411][BUILD] Fix release script to address type hint in pyspark/version.py#36803
Closed
HyukjinKwon wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-39411][BUILD] Fix release script to address type hint in pyspark/version.py#36803HyukjinKwon wants to merge 2 commits intoapache:masterfrom
HyukjinKwon wants to merge 2 commits intoapache:masterfrom
Conversation
MaxGekk
approved these changes
Jun 8, 2022
cloud-fan
approved these changes
Jun 8, 2022
Member
Author
|
Merged to master. The tests don't run this code path. |
Contributor
|
shall we merge to 3.3 as well? |
Member
Author
|
We always use master branch to release, no? |
Member
Author
|
let me backport just for sure in any event. |
HyukjinKwon
added a commit
that referenced
this pull request
Jun 8, 2022
…rk/version.py This PR proposes to address type hints `__version__: str` correctly in each release. The type hint was added from Spark 3.3.0 at f59e1d5. For PySpark to have the correct version in releases. No, dev-only. Manually tested by setting environment variables and running the changed shall commands locally. Closes #36803 from HyukjinKwon/SPARK-39411. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 87b0a41) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Contributor
No, we use branch-3.3 to release 3.3.x |
Member
Author
|
I read e.g., https://lists.apache.org/thread/tcjh5wlthg21j519tl7o25cdo81792vr vs. #25607 (comment) Using other branches is technically a workaround IIRC, and should probably make the master branch working |
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM.
Thank you for patching and backporting to branch-3.3.
HyukjinKwon
pushed a commit
that referenced
this pull request
Mar 26, 2024
…ound from release scripts ### What changes were proposed in this pull request? This PR aims to remove Spark 3.0~3.2 `pyspark/version.py` workaround code from release scripts. This is a logical revert of SPARK-38411 because Spark 3.0~3.3 are the end of support status. - #36803 ### Why are the changes needed? To simplify the release script for Apache Spark 4+ ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45706 from dongjoon-hyun/SPARK-47549. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to address type hints
__version__: strcorrectly in each release. The type hint was added from Spark 3.3.0 at f59e1d5.Why are the changes needed?
For PySpark to have the correct version in releases.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
Manually tested by setting environment variables and running the changed shall commands locally.